Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: POC fix for dev/core#5571. #416

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

twomice
Copy link

@twomice twomice commented Nov 6, 2024

Reference issue: https://lab.civicrm.org/dev/core/-/issues/5571

  • This solves the stated problem (upon validation of required checkbox/radio fields), and my own initial, manual, testing shows it doesn't break validation of required fields of other types.

Other thoughts:

  • I'm unfamiliar with the packages/ repo. Is a PR here even a reasonable thing to do?
  • Adding params to a method doesn't "feel great", but this is just a POC.
  • I'm unsure whether an equivalent fix would be relevant for similar method in these places:
    • packages/_ORIGINAL_/HTML/QuickForm/Renderer/ITStatic.php
    • packages/_ORIGINAL_/HTML/QuickForm/Renderer/ArraySmarty.php
    • packages/HTML/QuickForm/Renderer/ITStatic.php

Copy link

civibot bot commented Nov 6, 2024

(Standard links)

@civibot civibot bot added the master label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant