Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setTemplateDir to actually work #397

Merged
merged 1 commit into from
May 8, 2024

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented May 7, 2024

Overview

Fix broken backported function to support civicrm/civicrm-core#30148

Before

Function creates garbage.

After

Function does what it's supposed to do.

Copy link

civibot bot commented May 7, 2024

(Standard links)

@eileenmcnaughton
Copy link
Contributor

yeah - I guess this one doesn't need to work with the 'right' signature since it's hidden away in Smarty2

@eileenmcnaughton eileenmcnaughton merged commit c055c32 into civicrm:5.74 May 8, 2024
2 checks passed
@colemanw colemanw deleted the smartySetTemplateDir branch May 8, 2024 01:43
@demeritcowboy
Copy link
Contributor

Does this need a 5.73 port?

@colemanw
Copy link
Member Author

@demeritcowboy this ended up not being on the critical path for anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants