[REF][PHP8.1] Fix some further places where passing in NULL is deprec… #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
IDS/Converter.php
Outdated
| @@ -158,7 +158,7 @@ public static function convertFromJSCharcode($value) | |||
| if (preg_match_all('/\d*[+-\/\* ]\d+/', $char, $matches)) { | |||
| $match = preg_split('/(\W?\d+)/', | |||
| (implode('', $matches[0])), | |||
| null, | |||
| '', | |||
There was a problem hiding this comment.
3rd param is an int for preg_split?
There was a problem hiding this comment.
Otherwise PR looks good.
There was a problem hiding this comment.
ah good point will update to -1
There was a problem hiding this comment.
ok fixed now @demeritcowboy
There was a problem hiding this comment.
Cool. It turns out -1 and 0 mean the same thing in that spot (previously null would have been cast to 0).
…ated in php8.1 Fix parameter for preg_split
seamuslee001
force-pushed
the
packages_php81_3
branch
from
e6b489a to
27401fb
Compare
|
Jenkins retest this please. (Fails have been seen before I think as intermittent time-related, but let's check.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ated in php8.1
ping @eileenmcnaughton @demeritcowboy @totten @colemanw