Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes dev/core#2769 remove quickform hack - we are no longer calling this rule #329

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 24, 2021

It adds to confusion and we generally try to get our packages back to 'stock'

https://lab.civicrm.org/dev/core/-/issues/2769#note_63305

UPDATE - I thought civicrm/civicrm-core#21169 (comment) was merged - needs to be merged first

@seamuslee001 this is a follow up to the changes I did for https://lab.civicrm.org/dev/core/-/issues/2769 - ie we no longer need to hack quickform because we are doing validation within CRM and hacking it has downsides

  • confusion - per the gitlab
  • makes people think that hacking packages is 'ok' since we did it in place x
  • at some level all hacks need to be maintained & re-applied on upgrade - they have an ongoing cost

I don't know what over QF hacks we still have ....

@civibot
Copy link

civibot bot commented Aug 24, 2021

(Standard links)

@civibot civibot bot added the master label Aug 24, 2021
@eileenmcnaughton eileenmcnaughton changed the title dev/core#2769 remove quickform hack - we are no longer calling this rule Fixes dev/core#2769 remove quickform hack - we are no longer calling this rule Aug 24, 2021
@seamuslee001
Copy link
Contributor

Works for me

@seamuslee001 seamuslee001 merged commit 8be6c56 into civicrm:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants