Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#395 Define error messages for deadlock. #275

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Defines additional error messages for deadlocks. This is fairly deep in the code & not visible to users

Note there is some precedent for this in our codebase per https://issues.civicrm.org/jira/browse/CRM-14571 and I did an upstream PR
pear/DB#9 although I have no idea if it's likely to be reviewed since you know .... old

Before

When a deadlock is thrown the message winds up as DBError::Unknown Error

After

The error is identified as DBError::deadlock

Screen Shot 2019-12-19 at 9 50 53 AM

@civibot
Copy link

civibot bot commented Dec 18, 2019

(Standard links)

@civibot civibot bot added the master label Dec 18, 2019
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 can you take a look at this one - we rolled it out in prod the other day & have been better handling deadlocks in our own code. I also want to fix a core place where there is a misleading error which I can do with this (although I need to pin @totten down to talk about the best place to catch & retry deadlocks cos I think we got it wrong)

@seamuslee001
Copy link
Contributor

This works for me, AUG have deployed this to our production and its working well merging

@seamuslee001 seamuslee001 merged commit 4f0e6b5 into civicrm:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants