dev/core#395 Define error messages for deadlock. #275
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Defines additional error messages for deadlocks. This is fairly deep in the code & not visible to users
Note there is some precedent for this in our codebase per https://issues.civicrm.org/jira/browse/CRM-14571 and I did an upstream PR
pear/DB#9 although I have no idea if it's likely to be reviewed since you know .... old
Before
When a deadlock is thrown the message winds up as DBError::Unknown Error
After
The error is identified as DBError::deadlock