Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Net_UserAgent_Detect package #272

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Remove Net_UserAgent_Detect package #272

merged 1 commit into from
Dec 17, 2019

Conversation

seamuslee001
Copy link
Contributor

This removes the Net_UserAgent_Detect package that is no longer supported by Pear https://pear.php.net/package/Net_UserAgent_Detect and i cannot see anywhere that it is called at all

ping @eileenmcnaughton

@civibot civibot bot added the master label Dec 14, 2019
@civibot
Copy link

civibot bot commented Dec 14, 2019

(Standard links)

@seamuslee001
Copy link
Contributor Author

ping @demeritcowboy @mattwire

@demeritcowboy
Copy link
Contributor

demeritcowboy commented Dec 15, 2019 •
edited
Loading

Since this seems to be a follow-on about wordfence mistakenly flagging APC.php from stackexchange, I'll add that my own searching there suggested the same (that it isn't used). It seems to have been originally added as a dependency for paypal a looooonnnnng time ago.

@eileenmcnaughton
Copy link
Contributor

OK - I'm prepared to merge off your joint investigation

@eileenmcnaughton eileenmcnaughton merged commit 540c478 into civicrm:master Dec 17, 2019
@seamuslee001 seamuslee001 deleted the remove_net_useragent_detect branch December 17, 2019 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seamuslee001 @demeritcowboy @eileenmcnaughton