Fix dev/joomla#1 - Fix list of events shown when adding Event Info and Registration pages #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… page in Joomla Also fixes similar issue when adding an Event Regisration page
| 'return.start_date' => 1, | ||
| 'rowCount' => 100, | ||
| 'return' => array("title"), | ||
| 'start_date' => array('>=' => "today"), |
There was a problem hiding this comment.
No, we're looking for future events so where the start date is today or later.
| 'rowCount' => 100, | ||
| 'is_online_registration' => 1, | ||
| 'return' => array("title"), | ||
| 'start_date' => array('>=' => "today"), |
|
I'm going to merge this so it hits the rc - it seems there is a clearly agreed problem & you have worked on a fix - the fix is narrowly scoped & we are likely to struggle to get another Joomla! person to review - can you ask the reporter to test the 5.4 rc? |
|
Thanks for merging @eileenmcnaughton I have asked the reporter to test via SE |
aydun
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.