-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRM-20006 Standard groups relationships in views #507
Conversation
a38e3a3
to
93a28ec
Compare
Thanks @seamuslee001. I can test this later this week. |
'handler' => 'views_handler_sort', | ||
), | ||
); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new title is not included in view filters. Was this intentional? Though it contains the deprecated title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why but have updated it now @jackrabbithanna
@seamuslee001 I think if you address jitendrapurohit's question then after that this should be merged. |
@jitendrapurohit are you able to re-test this, looks like it was originally one of yours i rebased to get sorted would be good to get this merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tested this and confirm that the standard groups are correctly exposed in fields, filter and relationship section of the drupal view. +1 to get this included in core.
Thanks @seamuslee001
Merging per review by @jitendrapurohit & comments from @jackrabbithanna indicating this is an adequate review |
@jitendrapurohit this is a re-submit of #427 are you able to re-test?