Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM-20006 Standard groups relationships in views #507

Merged
merged 2 commits into from
Apr 22, 2019

Conversation

seamuslee001
Copy link
Contributor

@seamuslee001 seamuslee001 commented Dec 2, 2017

  • Expose standard group contact Relationship and be able to filter on status
  • Expose standard group Relationship for active and non hidden groups, and be able to filter on type and name
  • fix bug preventing to use the field 'group status'
  • add filter on group name (for cross-sites export)
  • Expose group custom data to group relationship.

@jitendrapurohit this is a re-submit of #427 are you able to re-test?


@jitendrapurohit
Copy link
Contributor

Thanks @seamuslee001. I can test this later this week.

'handler' => 'views_handler_sort',
),
);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new title is not included in view filters. Was this intentional? Though it contains the deprecated title.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why but have updated it now @jackrabbithanna

@jackrabbithanna
Copy link
Contributor

@seamuslee001 I think if you address jitendrapurohit's question then after that this should be merged.

@seamuslee001
Copy link
Contributor Author

@jitendrapurohit are you able to re-test this, looks like it was originally one of yours i rebased to get sorted would be good to get this merged

Copy link
Contributor

@jitendrapurohit jitendrapurohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested this and confirm that the standard groups are correctly exposed in fields, filter and relationship section of the drupal view. +1 to get this included in core.

Thanks @seamuslee001

@eileenmcnaughton
Copy link
Contributor

Merging per review by @jitendrapurohit & comments from @jackrabbithanna indicating this is an adequate review

@eileenmcnaughton eileenmcnaughton merged commit c0901e6 into civicrm:7.x-master Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants