CiviMail: don't pass unused job_id parameter to unsub methods #31811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
After #27531 and #29908
job_id
is not used inCRM_Mailing_Event_BAO_Queue::unsub_from_mailing
andCRM_Mailing_BAO_Mailing::addMessageIdHeader
so we don't need to pass that to it.Also removed unused
job_id
fromCRM_Mailing_Event_BAO_MailingEventUnsubscribe::unsub_from_domain
.Work towards https://lab.civicrm.org/dev/core/-/issues/4567
Before
Mailing Job ID is passed, but not actually used.
After
Job ID is not passed.