Skip to content

CiviMail: don't pass unused job_id parameter to unsub methods #31811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

semseysandor
Copy link
Contributor

@semseysandor semseysandor commented Jan 17, 2025

Overview

After #27531 and #29908 job_id is not used in CRM_Mailing_Event_BAO_Queue::unsub_from_mailing and CRM_Mailing_BAO_Mailing::addMessageIdHeader so we don't need to pass that to it.
Also removed unused job_id from CRM_Mailing_Event_BAO_MailingEventUnsubscribe::unsub_from_domain.
Work towards https://lab.civicrm.org/dev/core/-/issues/4567

Before

Mailing Job ID is passed, but not actually used.

After

Job ID is not passed.

Copy link

civibot bot commented Jan 17, 2025

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Jan 17, 2025
@semseysandor semseysandor marked this pull request as draft January 17, 2025 19:59
@semseysandor semseysandor force-pushed the job-id-unsub-from-domain branch from 7f9be7e to cd580d8 Compare January 17, 2025 22:24
@semseysandor semseysandor changed the title CRM_Mailing_Event_BAO_MailingEventUnsubscribe::unsub_from_domain remove unused job_id parameter CiviMail: don't pass unused job_id parameter to unsub methods Jan 17, 2025
@semseysandor semseysandor marked this pull request as ready for review January 17, 2025 22:35
@semseysandor
Copy link
Contributor Author

Now it's ready to review

@eileenmcnaughton
Copy link
Contributor

thanks @semseysandor !

@eileenmcnaughton eileenmcnaughton merged commit 6319192 into civicrm:master Jan 27, 2025
1 check passed
@semseysandor semseysandor deleted the job-id-unsub-from-domain branch January 29, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants