Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#5581 Expose php & smarty compatibility #31651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 22, 2024

Overview

dev/core#5581 Expose php & smarty compatibility

Before

No visibility over whether extensions are compatible with various smarty & php versions. For example recent releases of extendedreports are not compatible with smarty 2 and recent Omnipay is not compatible with PHP 7.4 - however there is no clue to that in the UI or the extension download system. In both cases they could cause obscure hard fails so this could be important information.

After

The compatibility can now be declared in the same way as the CiviCRM compatibility. At this point very few extensions will be declaring their compatibility so it will be of limited use to end users - but with the facility to declare it we can start to add the declarations into extensions

image

image

Technical Details

Comments

Copy link

civibot bot commented Dec 22, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Dec 22, 2024
Copy link

civibot bot commented Dec 22, 2024

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5581

{/if}
</td>
</tr>
<td class="label">{ts}Compatible with{/ts} (CiviCRM)</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're trying to save on translation by reusing the same string multiple times but some languages change the order of words, so these might translate oddly. I think I would just put the full thing in ts each time, in case maybe some languages don't capitalize "PHP" or use brackets differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants