dev/core#5587, dev/core#5560 - bring back validation of emails in profiles

[demeritcowboy]

Overview

• https://lab.civicrm.org/dev/core/-/issues/5587
• https://lab.civicrm.org/dev/core/-/issues/5560

Before

Since 5.75:

1. Visit e.g. a standalone profile in create mode, or e.g. an event registration, that uses a profile containing either email or openid.
2. Enter an invalid email, or an openid that isn't in url format.
3. It will accept it.

After

1. Like before.

Technical Details

The xml schema used to contain a <rule> for 3 fields, one of them being email. This is used when building the profile to add a form rule. Since it was only 3 fields, one of them deprecated, it didn't get copied over to the new way.
See ticket for more details.

Technically I should also update user_unique_id's input type to be Url the same as openid because that's what it was before, but it's marked deprecated and I couldn't see how to add it to a profile.

Comments

This isn't a "beautiful" fix but I don't know where else to put it. There's a little discussion in ticket.

I'm not sure openid is even working in profiles. I think this is a separate issue. Note to see it on the contact you have to enable it under Display Preferences, but even then it doesn't seem to get stored when entered in a profile form. But at least now the validation will work.

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5587

[colemanw]

Beautiful or not, it's better fixed than not-fixed.
Thanks @demeritcowboy