Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#5370 Fix bug handling soft credits in civi-import #30818

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

eileenmcnaughton
Copy link
Contributor

partial port of #30807

This ensures the userJob is saved at the js layer before the php layer kicks in.
If the js layer save does NOT run first it causes bugs like those
described in https://lab.civicrm.org/dev/core/-/issues/5370
Copy link

civibot bot commented Aug 8, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the 5.75 label Aug 8, 2024
Copy link

civibot bot commented Aug 8, 2024

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/5370

@totten
Copy link
Member

totten commented Aug 8, 2024

Most of the testing was on the original PR. Just as a sanity-check of the backport, I made sure that the UI was generally loading (and that an import-mapping was saved).

@totten
Copy link
Member

totten commented Aug 8, 2024

Most tests pass. The last remaining test-suite would run for a while, but I'm gonna go ahead and merge. That test is pure-PHP, and this update is pure client-side JS, so there's no plausible path to true-negative.

@totten totten merged commit 2713c2a into civicrm:5.75 Aug 8, 2024
1 check was pending
@totten totten deleted the 575_i branch August 8, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants