Alternate fix to remove extraneous tax display

[eileenmcnaughton]

Overview

@jitendrapurohit what about this as an alternative to #29859

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[eileenmcnaughton]

test this please

[jitendrapurohit]

Thank you for the fix @eileenmcnaughton. Confirmed this is working fine 👍

[seamuslee001]

@eileenmcnaughton test fail seems to relate

CRM_Contribute_Form_ContributionTest::testEmailReceiptOnPayLater with data set #0 (true)
Error: Typed property CRM_Contribute_Form_Contribution::$order must not be accessed before initialization

/home/homer/buildkit/build/build-2/web/sites/all/modules/civicrm/CRM/Contribute/Form/Contribution.php:939
/home/homer/buildkit/build/build-2/web/sites/all/modules/civicrm/CRM/Contribute/Form/Contribution.php:971
/home/homer/buildkit/build/build-2/web/sites/all/modules/civicrm/CRM/Contribute/Form/Contribution.php:618
/home/homer/buildkit/build/build-2/web/sites/all/modules/civicrm/CRM/Core/Form.php:774
/home/homer/buildkit/build/build-2/web/sites/all/modules/civicrm/Civi/Test/FormWrapper.php:143
/home/homer/buildkit/build/build-2/web/sites/all/modules/civicrm/tests/phpunit/CRM/Contribute/Form/ContributionTest.php:2148
/home/homer/buildkit/build/build-2/web/sites/all/modules/civicrm/tests/phpunit/CRM/Contribute/Form/ContributionTest.php:625
/home/homer/buildkit/build/build-2/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:284
/home/homer/buildkit/extern/phpunit9/phpunit9.phar:2307

[eileenmcnaughton]

@seamuslee001 yeah - I opened a couple or PRs to tackle some of those side-issues - this was one #29907

[eileenmcnaughton]

& also #29903

[eileenmcnaughton]

I don't think I did the last one - was kinda on hold for those others

[seamuslee001]

Jenkins re test this please

[eileenmcnaughton]

I've brought this back to the actual issue - I think it will still hit a notice - likely fixed by this #29936 & one other

[eileenmcnaughton]

Just the one fail - I expect #29936 to address

CRM_Contribute_Form_ContributionTest::testEmailReceiptOnPayLater with data set #1 (false)
Undefined array key "tax_amount"

/home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/CRM/Price/BAO/PriceField.php:786
/home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/CRM/Price/BAO/PriceField.php:497
/home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/CRM/Contribute/Form/Contribution.php:963
/home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/CRM/Contribute/Form/Contribution.php:615
/home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/CRM/Core/Form.php:774
/home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/Civi/Test/FormWrapper.php:143
/home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/tests/phpunit/CRM/Contribute/Form/ContributionTest.php:2148
/home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/tests/phpunit/CRM/Contribute/Form/ContributionTest.php:625
/home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:284
/home/homer/buildkit/extern/phpunit9/phpunit9.phar:2307

[seamuslee001]

Jenkins re test this please

[eileenmcnaughton]

@seamuslee001 looks like this is mergeable now

[eileenmcnaughton]

Merging based on @jitendrapurohit's review