Clean up parameters in add payment form

[eileenmcnaughton]

Overview

Clean up parameters in add payment form

Before

The code in this form was copied from another form (back when the form was created). A lot of the code is for the contribution to be created - but this form never interacts with the contribution create/update method - it only calls Payment.create - hence making up an invoiceID & passing it to doPayment & never using it is unhelpful. LIkewise calling the function to format contribution custom fields

After

The fields passed to the Payment.create are assembled in one place so it is clear where they are coming from

Technical Details

I'm trying to fix the fact this form doesn't create the billing address - but fighting with confusing code

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[mattwire]

@eileenmcnaughton test fails relate

[eileenmcnaughton]

CRM_Contribute_Form_AdditionalPaymentTest::testAddPaymentForPartiallyPaidContribution
substr(): Passing null to parameter #1 ($string) of type string is deprecated

/home/homer/buildkit/build/build-1/web/sites/all/modules/civicrm/CRM/Contribute/Form/AdditionalPayment.php:330
/home/homer/buildkit/build/build-1/web/sites/all/modules/civicrm/CRM/Contribute/Form/AdditionalPayment.php:294
/home/homer/buildkit/build/build-

[eileenmcnaughton]

cool - heaps of tests on it - hopefully that casting fixes

[eileenmcnaughton]

mixin test fails only this time - test this please

[eileenmcnaughton]

test fail unrelated test this please

[PHP Warning] Undefined array key "name" at /home/homer/buildkit/build/buil
d-1/web/sites/all/modules/civicrm/Civi/Api4/Action/Setting/GetFields.php:44
[PHP Warning] Undefined array key "name" at /home/homer/buildkit/build/buil
d-1/web/sites/all/modules/civicrm/Civi/Api4/Action/Setting/GetFields.php:44
[PHP User Warning] Smarty error: unable to read resource: "CRM/Shimmy/
Example.tpl" at /home/homer/buildkit/build/build-1/web/sites/all/modul
es/civicrm/packages/Smarty/Smarty.class.php:1100
[PHP User Warning] Smarty error: unable to read resource: "CRM/Shimmy/
Example.tpl" at /home/homer/buildkit/build/build-1/web/sites/all/modul
es/civicrm/packages/Smarty/Smarty.class.php:1100
Skip. No tests found for theme-php@1
Error processing mixins: setting-admin@1