Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkbox JS regression for import data selection and email new te… #27132

Conversation

larssandergreen
Copy link
Contributor

Overview

Regression from #26598. That PR changed the signature of add() for a checkbox, breaking these two checkboxes which no longer had their onchange added as it was in $extra, which is now ignored.
These are the only two that show up by searching.

Before

  1. On Contact - New Email, clicking the Save as New Template doesn't show the template name field.
  2. In Import, if you add a data file, go to the next step, then go back, the Use data already uploaded checkbox doesn't show/hide fields below it as intended.

After

Show/hide works as intended.

@civibot
Copy link

civibot bot commented Aug 24, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@larssandergreen
Copy link
Contributor Author

Jenkins test this please

@eileenmcnaughton
Copy link
Contributor

test fail looks unrelated - test this please

@colemanw
Copy link
Member

retest this please

@colemanw
Copy link
Member

Gives me a warm feeling to know that, although the rest of the world has shunned it, we at CiviCRM still have room in our hearts for that old onclick html attribute.

@demeritcowboy demeritcowboy merged commit 08ad59a into civicrm:5.65 Aug 24, 2023
@demeritcowboy
Copy link
Contributor

I don't know if there'll be another 5.64 release but might be worth a backport?

@demeritcowboy demeritcowboy mentioned this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants