CiviGrant - Fix error when creating grant without permissions #26513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a grant with checkPermissions disabled (e.g. via API) the permissions were getting tripped by the RecentItem create action
|
(Standard links)
|
|
Weird unrelated failures I've been seeing for a few days intermittently in the upgrade tests. |
|
Fails have been happening for a while. I had made a lab ticket https://lab.civicrm.org/infra/ops/-/issues/995. |
|
I just ran into this - it looks like this was committed against the master branch? Was that intentional? |
|
It was backported against 5.63 but not 5.62. I don't know if there's going to be another 5.62 release. Maybe ask in prod maint? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a regression in CiviGrant
Before
When creating a grant with checkPermissions disabled (e.g. via API) the permissions were getting tripped by the RecentItem create action.
After
Works correctly with and without permissions.
Technical Details
Regressed due to switch from direct call to API call in 18cbf9f