-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify messaging for event confirm page #26469
Conversation
(Standard links)
|
This includes latest changes based on @colemanw and @larssandergreen comments
Now says "your information".
No, it's fine. Because entering payment directly on the page will say "Click Register to complete your registration." and it will give a validation error if the payment details are not completed. I also moved the div outside of the if statements so we only need to add it once instead of 3 times. |
94022de
to
00d8c49
Compare
This looks perfect to me. Thanks for not giving up on what can seem bikeshed, but really important for end-users. Slight nitpick, and I'm happy to do so on a separate PR: since we are breaking translation strings, I would replace |
93df05e
to
00d8c49
Compare
00d8c49
to
6ff09ca
Compare
@mlutfy There you go - updated from span class=bold to strong |
@mattwire you rock, thank you :) (added merge-ready to leave time to other folks to comment) |
Big improvement! Appreciate this. My concern with payment on confirm is more that "Please verify your information. Click Register to complete your registration." might suggest that the user doesn't need to do anything other than verify or maybe not verify because they don't care to (when in fact they need to enter their payment details). It's very obvious that you need to enter payment details if there are a bunch of credit card forms, but if there is an option to select the payment processor, it's less clear. But not a big deal at all, they'll get a validation error anyways. |
FWIW, I rather like @colemanw's "Almost done!" suggestion (from the prior thread). It's very easy to confuse a confirmation and a receipt. For me, that phrase is very quick/short and removes ambiguity. ("Please verify..." ==> If you show me a receipt and ask me to "verify", I may assume that it's passive verification -- you only respond if there's a problem. The rest of the text does tell the reader to take more action, but I don't always read everything. If I just read the first 2 words, then "Almost done!" tells me more than "Please verify...") However, that's not a hard-block from me. The "Almost done" thing is an improvement IMHO, but the current text is OK. |
I also don't want to block this as it's already a big improvement. |
I'm changing my tune, the argument is convincing, and support Almost Done! |
I'm not too fond of the "Almost done!", but I'll go with the flow. Not everyone is going to feel comfortable with the wording (feels US-centric, and the translations will be painful). The extra wording feels like duct-tape. We struggle with this screen because the call-to-action is not obvious. It's better now, with the simplified text, but I agree it could be improved. With this PR, it would look like this: If we wanted a clear call to action, we would need something like this: or maybe more explicit: If the person really reviewed something and wants to go back, I would leave the "back" button at the bottom of the screen. |
I really like @mlutfy's idea to change the button text to Complete Registration or something similar. Could we entirely eliminate this text in the default case if we did that (still having text for waitlist, approval and off-site payment)? I think we could! Might have to move the button down to below the payment block for payment on confirm, which would make more sense anyways. |
I liked the "Almost done" idea but wasn't sure what we'd do with the other scenarios (ie. waitlist, require approval etc.). Technically splitting the location of the buttons is more difficult because they are rendered using a standard template. But I do like the screenshots of @mlutfy I took @larssandergreen suggestion of using smarty variables for the button names so the text could easily be updated in a future PR without breaking translations. |
I think we should go ahead and merge. Everyone agrees that this is better than status-quo. There maybe other improvements, and I do like the idea of visual-cues to make the button more obvious. But it sounds like the other improvements have their own subdiscussions. (Like: "How does a special-button play on different themes?" or "How does 'Almost done!' sound to ESL audience?") Better to get this in, and other improvements can go to other PRs. |
Thanks @totten |
I really appreciate all the work that has gone into this @mattwire . As I was checking everything out I felt that the buttons that @mlutfy are propose are really clear and directive, which I feel we want in a form. In the verification screen, it can be confusing (as people have mentioned) what is happening and whether it's receipt or not. Also, people sometimes skip over the text at the top and scroll right down. If we were modify this in the future i would propose changing the buttons to :
|
Overview
Replaces #26182 which stopped pulling in rebased changes for some reason.
The text on the confirm page hasn't changed for at least 10 years and there is a lot of it! This PR removes some and simplifies the rest to make it quicker / easier to read and hopefully clearer.
Before
After
Removes bottom block of text explaining how to use buttons.
Text at the top is shortened and simplified.
Technical Details
Comments