Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP warning on Export Contacts #26467

Conversation

larssandergreen
Copy link
Contributor

@larssandergreen larssandergreen commented Jun 7, 2023

Overview

merge_same_household is never set and it isn't clear what it might be for. Possibly it was copy-paste from Print Labels or possibly it was meant to be implemented in some way similar to the greetings merging options for Same Address here, but there's no sign of that having been done at all (the show-hide JS here only deals with Same Address). Either way, it does nothing and causes PHP warnings (see SE here), so it should go.

Before

PHP warnings

After

Gone

@civibot
Copy link

civibot bot commented Jun 7, 2023

(Standard links)

@colemanw
Copy link
Member

colemanw commented Jun 7, 2023

Thanks @larssandergreen! "Probably copy-paste" is usually a good rationale for weird inexplicable code.

@eileenmcnaughton eileenmcnaughton merged commit f567409 into civicrm:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants