Order mailings for selects in search and reports by id DESC

[larssandergreen]

Overview

Mailing name selects (in Advanced Search, various reports) are ordered by name. Assuming you have more than a few mailings, this is not very useful. If I'm searching for mailings and I start typing the name of the mailing, I want to see the most recent mailings at the top of the list, not have them sorted by name. This also allows the user to select the most recent mailings directly from the top of the list.

Before

Mailing selects sorted by name.

After

Mailing selects are sorted by mailing id descending, so most recent mailings are at the top of the list.

Technical Details

This function is only used in CRM/Mailings/BAO/Query (it has another use in here, but the order doesn't matter for that) and the five Mailing reports. No other uses in universe except one similar use in a report in SendGrid extension.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[aydun]

Good idea

[Stoob]

Added for illustration

[larssandergreen]

@Stoob Are those not ordered by mailing id (which should be the same ordering as created date)? Or are you saying we should do something more complex that orders by scheduled date if present, but modified or created date if not? I like id because it is guaranteed fast and that's not the case if ordered by multiple non-indexed fields.

[Stoob]

My comment was for illustrative purposes only, showing how they mailings are currently ordered alphanumberic asc by name. I personally think yours is a good proposal to order mailings by ID desc instead. I have asked a few clients to review this proposal as well

[magnolia61]

Nice one! I agree and would also suggest ordering by sent (primary), scheduled (secondary).

PS. Same applies for ordering of event registrations.