Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#3570: Don't show current mailing in include/exclude previous mailings #26427

Conversation

larssandergreen
Copy link
Contributor

Before

You can include or exclude the current mailing recipients from your mailing, which makes no sense.

After

Current mailing does not appear in the options to include or exclude.

@civibot
Copy link

civibot bot commented Jun 4, 2023

No issue was found matching the number given in the pull request title. Please check the issue number.

@civibot
Copy link

civibot bot commented Jun 4, 2023

(Standard links)

@civibot civibot bot added the master label Jun 4, 2023
@larssandergreen larssandergreen force-pushed the Don't-show-current-mailing-in-include/exclude-mailings branch from 92cabaf to 5a08829 Compare June 4, 2023 13:22
@colemanw
Copy link
Member

colemanw commented Jun 4, 2023

I'm currently working on refactoring this entire widget to use APIv4, but thanks, this is a good reminder to not let the user do silly things.

@colemanw colemanw merged commit 21c2ff6 into civicrm:master Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants