[REF][PHP8.2] Sort out dynamic properties in api_v3_ReportTemplateTest #26414
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Sort out dynamic properties in
api_v3_ReportTemplateTest
Before
Dynamic properties in
api_v3_ReportTemplateTest
cause deprecation warnings in PHP 8.2After
Dynamic properties no longer.
The
$this->entity = 'Contact';
line was no longer needed ascreateCustomGroup
(which used to use it) now defaults to'Contact'
.Comments
Tons of report tests are failing on PHP 8.2. due to missing tables. I think it's happening because a
tearDown
isn't running correctly, but I don't expect this to actually address that issue.