Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF][PHP8.2] Sort out dynamic properties in api_v3_ReportTemplateTest #26414

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

braders
Copy link
Contributor

@braders braders commented Jun 2, 2023

Overview

Sort out dynamic properties in api_v3_ReportTemplateTest

Before

Dynamic properties in api_v3_ReportTemplateTest cause deprecation warnings in PHP 8.2

After

Dynamic properties no longer.

The $this->entity = 'Contact'; line was no longer needed as createCustomGroup (which used to use it) now defaults to 'Contact'.

Comments

Tons of report tests are failing on PHP 8.2. due to missing tables. I think it's happening because a tearDown isn't running correctly, but I don't expect this to actually address that issue.

@civibot
Copy link

civibot bot commented Jun 2, 2023

(Standard links)

@civibot civibot bot added the master label Jun 2, 2023
@colemanw colemanw merged commit 35a1d26 into civicrm:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants