Use Permission=FALSE when retrieving price sets in examples #26399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
| @@ -158,7 +158,7 @@ private function addExampleData(GenericWorkflowMessage $messageTemplate, $exampl | |||
| */ | |||
| private function getNonQuickConfigPriceSet(): ?array { | |||
| // Permission check defaults to true - likely implicitly OK but may need to be false. | |||
| return PriceSet::get() | |||
| return PriceSet::get(FALSE) | |||
There was a problem hiding this comment.
the comment above it could go too
There was a problem hiding this comment.
@demeritcowboy good spotting - I grepped for it & found one more place to change to FALSE
demeritcowboy
added
the
merge ready
Doing a check causes the whole example to fail - and this feels like fairly public info
demeritcowboy
added
merge on pass
and removed
merge ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a check causes the whole example to fail -
and this feels like fairly public info