SearchKit: Don't show the pager unless it is needed

[larssandergreen]

Overview

We don't need to show the pager in Search Displays if the number of rows is less than the page size.

Before

E.g. Manage Contribution Pages, pager just taking up space.

After

No more pager.

If you adjust the page size, the pager is shown as appropriate.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[larssandergreen]

jenkins test this please

[larssandergreen]

jenkins test this please

[aydun]

Looks good to me but let's see what @colemanw says

[colemanw]

I don't entirely agree with this change. In general, when an element is not usable we display it as "disabled" rather than hiding it completely (search button, actions menu, unavailable actions). IMO that makes for a less-confusing UX. And I don't quite see the argument for "taking up space" being a problem, since the upshot of having fewer results than the limit is that the display will already take up less space than normal.
I would support making this a configurable option so the admin can choose this behavior if they wish. (and the configuration screen for table displays has grown quite cluttered so we probably need to start thinking about organizing it better).

[larssandergreen]

Sure, we could do it as an option instead. I think it would be good to be able to have something like this for Admin UI, where in many cases there won't be a second page and we don't really need a disabled pager at the bottom of each. I agree that it doesn't make much difference for something like a contact search. Will do.

And agreed on the organization of the options.

[larssandergreen]

@colemanw Are you happy if I add this option to the existing Admin UI displays?

[colemanw]

@larssandergreen that sounds fine. We don't need to block progress just because the admin screen is cluttered, go ahead and add to it and we can try to de-clutter at some point.

[larssandergreen]

@colemanw Will do, but I meant, are you happy to hide the pager when there is only one page for existing AdminUI Displays, like on Manage Contribution Pages in the example I gave. Looking through them, I think the only one that could be an edge case is Manage Groups, that one could go either way, the remainder I think really don't need the pager as most installs will probably never hit 50 of them.

[colemanw]

Ok @larssandergreen yes I'm fine with that.

[larssandergreen]

OK, great, @colemanw, I've pushed two commits, one adds the hide_single option (and re-orders the pager options to make a little more sense), the other adds hide_single to all the Admin UI forms. Also added show_count and expose_limit to Groups and Scheduled Jobs for consistency.

[colemanw]

Ok thanks @larssandergreen - looks great.