Fix receive_date error saving on Edit Participant with Record Contribution #26388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
@JoeMurray describes how to reproduce this issue here:
The issue was that receive_date was an empty string, so the check this PR replaces wasn't changing it to a default date. In some cases, that causes a DB error. On dmaster, it creates the contribution and transaction with an empty date. Not sure why the behaviour is different, but that doesn't really matter, because it is broken either way.
Before
Can't save Participant or Contribution created with empty receive_date if no receive_date entered on the form.
After
Participant saved as normal, Contribution created with current date and time or as entered on form.