dev/core#4325 Fix extra brs in custom field note rich text

[larssandergreen]

Before

Extra brs in the rich text and doubled brs in the plain text.

After

Paragraphs in the rich text and single brs in the plain text. We let Core/BAO/CustomField add the nl2br.

Comments

I can't figure out how to get into multiRecordDisplay=single mode, so haven't been able to test that. I tested this with a custom field on an Activity, display of custom fields on a Contact appears to be different and does not have this problem.

[civibot]

No issue was found matching the number given in the pull request title. Please check the issue number.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[larssandergreen]

unrelated test fail
jenkins, test this please

[demeritcowboy]

I think I was wrong in the ticket about the plain text textarea needing nl2br. Or maybe somewhere else is already adding it in beforehand. It seems like nl2br can be taken out regardless (at least on an activity).

[larssandergreen]

@demeritcowboy Yes, it's getting the old double nl2br for good measure, once here as well.

[larssandergreen]

Pushed a new version that removes the double nl2br, so also improves plain text fields. Updated screenshots.

[demeritcowboy]

For multisingle I think it would be something like this: http://core-26386-3jm2o.test-1.civicrm.org:8001/civicrm/contact/view/cd?reset=1&gid=5&cid=9&recId=1&cgcount=1&multiRecordDisplay=single&mode=view

But you can't have multi custom sets for activities, just contacts.