Mailing Report: when scheduled, displays stats so that we can see recipient count and scheduled date #26378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
…ipient count and scheduled date
mlutfy
force-pushed
the
mailingReportScheduled
branch
from
8ae57e1 to
753b1cf
Compare
mlutfy
commented
May 30, 2023
| @@ -149,7 +145,7 @@ | |||
| {/if} | |||
|
|
|||
| <fieldset> | |||
| <legend>{ts}Content / Components{/ts}</legend> | |||
| <legend>{ts}Content{/ts}</legend> | |||
There was a problem hiding this comment.
I also did a sneaky update here to remove nerdy jargon.
(this does not break translations, the string "Content" already exists)
after:
|
Looks good to go to me on review, r-run shows no issues. Agreed that it is best just to show everything for scheduled mailings. Like the sneaky update too. |
|
thank you @larssandergreen ! I will add merge-ready, since it has been reviewed, but I cannot self-merge. |
mlutfy
added
the
merge ready
|
@mlutfy it's perfectly fine to merge a PR that has passed review (even if you are the author!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When a Mailing is Scheduled, CiviCRM kindly informs us that the delivery has not yet begun, and that we maybe have a technical issue if the mailing scheduled date is in the past. However, we cannot see the Scheduled Date from that screen.
So you have to look at the URL, find the "id", and then go back to "mailings" and hover the report links to confirm the Scheduled Date.
Before
After
Technical Details
I only moved the warning up, restructured the "if/else" (despite the large number of lines changed).
Comments
I have also had feedback from admins that they couldn't see the number of intended recipients until the mailing starts, so it feels fine to show most of the data while it's Scheduled.