Fix PHP8 warning on DedupeFind

[larssandergreen]

Overview

When group id isn't passed to DedupeFind, we get a warning.

Passing gid=0 or NULL doesn't fix the error, there must be some code that doesn't set the variable if it isn't truthy.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

The only problem is this won't be compatible with CIVICRM_SMARTY_DEFAULT_ESCAPE. Which reminds me I need to do something with this.

[larssandergreen]

@demeritcowboy Right, I forgot about that one.

I was looking at Form/DedupeFind.php and I should have been looking at Page/DedupeFind.php, now things make more sense, have pushed a new version that fixes this properly.

Yes, would be great to add those details to the docs. It's hard to find on Gitlab.

[demeritcowboy]

What is gid? I can't see anywhere it gets passed in, but even if it did, with regard to this notice, all it does is pass it on in the ajax call to toggleDedupeSelect, which calls CRM_Contact_Page_AJAX::toggleDedupeSelect, which doesn't use it.

Maybe this is one of those where the notice is trying to tell us something?

[larssandergreen]

gid is the group id for limiting matches to a group. It is passed in from the URL.

But you are right that it (and in fact rgid as well) are not needed by toggleDedupeSelect, so I think we can cut them. Pushed a new version that does that.

I don't know what snippet=4 is doing there, so I'm not going to touch it.