Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF][PHP8.2] Replace property with variable in OrderTest #26368

Merged
merged 1 commit into from
May 29, 2023

Conversation

braders
Copy link
Contributor

@braders braders commented May 29, 2023

Before

api_v3_OrderTest used a dynamic property _eventId, despite it only being used in a single function. This use of a dynmaic property is deprecated in PHP 8.2, and therefore the test failed.

After

A standard variable in used, the test passes on PHP 8.2

@civibot
Copy link

civibot bot commented May 29, 2023

(Standard links)

@civibot civibot bot added the master label May 29, 2023
@demeritcowboy demeritcowboy merged commit 231ac62 into civicrm:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants