Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] CRM_Core_StateMachine::addSequentialPages(): don't pass extra parameter #26367

Merged
merged 1 commit into from
May 29, 2023
Merged

[REF] CRM_Core_StateMachine::addSequentialPages(): don't pass extra parameter #26367

merged 1 commit into from
May 29, 2023

Conversation

semseysandor
Copy link
Contributor

Overview

CRM_Core_StateMachine::addSequentialPages() method signature has 1 parameter (&$pages), but it's called with 2 parameters.

Before

Extra $action param is passed.

After

2nd parameter removed from all method calls.

@civibot
Copy link

civibot bot commented May 29, 2023

(Standard links)

@civibot civibot bot added the master label May 29, 2023
@demeritcowboy demeritcowboy merged commit 30f7669 into civicrm:master May 29, 2023
@demeritcowboy
Copy link
Contributor

Wow some ancient untouched code.

@semseysandor semseysandor deleted the statemachine-extra-param branch May 29, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@semseysandor @demeritcowboy