Fix missing error on Transfer Participant and allow multiple #26365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
May 30, 2023
colemanw
reviewed
May 30, 2023
CRM/Event/Form/SelfSvcTransfer.php
Outdated
| @@ -288,7 +295,8 @@ public static function checkRegistration($fields, $self, $contact_id, &$errors) | |||
| if (!empty($to_event_id)) { | |||
| foreach ($to_event_id as $id) { | |||
| if ($id == $self->_event_id) { | |||
| $errors['email'] = $display_name . ts(" is already registered for this event"); | |||
| $error_field = $fields['contact_id'] ? 'contact_id' : 'email'; | |||
There was a problem hiding this comment.
Is this array key always set or do you need to use !empty()?
There was a problem hiding this comment.
Yes, fixed. Actually, further testing showed this was a little funky because it was only matching on email and so if you entered an email address with a different name, it came back with an error about the name associated with that email address, when the email address was the actual error, so I've corrected that too.
larssandergreen
force-pushed
the
Show-already-registered-error-on-Transfer-Participant
branch
2 times, most recently
from
9d5c5bb to
2f5896d
Compare
larssandergreen
force-pushed
the
Show-already-registered-error-on-Transfer-Participant
branch
from
2f5896d to
a0ebf09
Compare
|
I decided just to fix the whole function properly, the way it worked was a bit silly and hard to read. |
|
jenkins, test this please (failures don't look related) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
If you attempt to transfer an event registration to a contact who is already registered for an event on the back end, the form fails validation, but no error is shown.
If you attempt to transfer an event registration to a contact who is already registered for an event when Allow same email and multiple registrations? is enabled, you cannot transfer the registration.
After
You can transfer an event registration to an already registered contact if Allow same email and multiple registrations? is enabled.
An error is shown on both front and back end if you cannot transfer an event registration because the contact is already registered for the event.