Don't show refund due when balance is owed on Additional Payments #26358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
If a contributor owes an amount on a contribution, if you click Record Refund, the form incorrectly shows
Refund Due: $N
when $N is actually the balance owed. The amount field is also set by default to the balance owed when you are in fact recording a refund.The Submit Credit Card payment submit button says
Record Payment
.After
If the contributor owes an amount on a contribution, if you click Record Refund, the form correctly shows
Balance Owed: $N
instead ofRefund Due: $N
. The amount field is only set by default if there is a refund due.The Submit Credit Card payment submit button says
Submit Payment
.Comments
$this->_owed
and$this->amountDue
are the same when$this->_owed
is TRUE, so no need to check both.