Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show refund due when balance is owed on Additional Payments #26358

Conversation

larssandergreen
Copy link
Contributor

@larssandergreen larssandergreen commented May 27, 2023

Before

If a contributor owes an amount on a contribution, if you click Record Refund, the form incorrectly shows Refund Due: $N when $N is actually the balance owed. The amount field is also set by default to the balance owed when you are in fact recording a refund.

image

The Submit Credit Card payment submit button says Record Payment.

After

If the contributor owes an amount on a contribution, if you click Record Refund, the form correctly shows Balance Owed: $Ninstead of Refund Due: $N. The amount field is only set by default if there is a refund due.

image

The Submit Credit Card payment submit button says Submit Payment.

Comments

$this->_owed and $this->amountDue are the same when $this->_owed is TRUE, so no need to check both.

@civibot
Copy link

civibot bot commented May 27, 2023

(Standard links)

@civibot civibot bot added the master label May 27, 2023
@larssandergreen larssandergreen changed the title Don't show incorrect refund owed on Additional Payments Don't show refund owed when balance is owing on Additional Payments May 27, 2023
@larssandergreen larssandergreen changed the title Don't show refund owed when balance is owing on Additional Payments Don't show refund owed when balance is owed on Additional Payments May 27, 2023
@larssandergreen larssandergreen changed the title Don't show refund owed when balance is owed on Additional Payments Don't show refund due when balance is owed on Additional Payments May 27, 2023
@demeritcowboy demeritcowboy merged commit da4876e into civicrm:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants