Don't show events without end date forever on Manage Events #26347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Since end date is not required for events, I find users often leave it blank for events that are just one day. Consequently, those events hang around on Manage Events with the default
Show Current and Upcoming Events
forever. I can't really see the utility of having open ended events shown here as it seems like it is the nature of events to end (without getting too philosophical here). If anyone is in fact using open-ended events, they can still find them by usingSearch All or by Date Range
.Before
Events without end date show forever.
After
Events without end date are no longer shown 1 day after their start date.
Comments
The Events Dashboard is doing something completely different, only searching for events that started in the last 7 days and ignoring end date. I could bring this logic over there if people feel it would be helpful, but that one is written in pure SQL.