Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show events without end date forever on Manage Events #26347

Conversation

larssandergreen
Copy link
Contributor

@larssandergreen larssandergreen commented May 25, 2023

Overview

Since end date is not required for events, I find users often leave it blank for events that are just one day. Consequently, those events hang around on Manage Events with the default Show Current and Upcoming Events forever. I can't really see the utility of having open ended events shown here as it seems like it is the nature of events to end (without getting too philosophical here). If anyone is in fact using open-ended events, they can still find them by using Search All or by Date Range.

Before

Events without end date show forever.

After

Events without end date are no longer shown 1 day after their start date.

Comments

The Events Dashboard is doing something completely different, only searching for events that started in the last 7 days and ignoring end date. I could bring this logic over there if people feel it would be helpful, but that one is written in pure SQL.

@civibot
Copy link

civibot bot commented May 25, 2023

(Standard links)

@civibot civibot bot added the master label May 25, 2023
@mattwire mattwire merged commit ef83ac3 into civicrm:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants