Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mailing view and preview paths to schema #26342

Conversation

larssandergreen
Copy link
Contributor

Overview

Would be nice to have more than just the Edit option in SearchKit.

Before

image

After

Adds View for the Mailing Report and Preview for the mailing content.
image

Technical Details

Of course, these links will or won't work depending on the state of the mailing (draft versus scheduled), but better to have them than to not. I don't think there's a way to show or not show them depending on the particular mailing (@colemanw please correct me if I'm wrong).

I tried to add Delete as well, but it turns out that Mailing Delete uses civicrm/mailing/browse which uses an onclick confirmation for deletion, which I don't think we can use with just a path, so that would require some additional work and I'll leave that for another day.

@civibot
Copy link

civibot bot commented May 25, 2023

(Standard links)

@civibot civibot bot added the master label May 25, 2023
@colemanw
Copy link
Member

This looks good @larssandergreen but regenerating civicrm_generated is not necessary when simply adding tags like this. You can remove that commit like

git reset --hard HEAD~1&&git push -f

To your other question, yes! SearchKit allows conditional rules for links. You can't define that in the schema though, it has to be configured when you are making a SearchDisplay.

@larssandergreen larssandergreen force-pushed the Add-mailing-paths-to-schema-and-SK branch from d3f99cf to 1eb88c4 Compare May 25, 2023 15:37
@larssandergreen
Copy link
Contributor Author

@colemanw Great, thanks, have done.

@seamuslee001 seamuslee001 merged commit 5d3b597 into civicrm:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants