Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Add sticky table header style #26330

Merged
merged 1 commit into from
May 25, 2023

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented May 24, 2023

Overview

Allows SearchKit table displays to have "sticky" headers which don't scroll past the top of the screen.

Screenshot 2023-05-24 at 10 50 35 AM

Technical Details

The tricky part was figuring out the exact location to "stick" to. The position of the bottom of the menubar is different depending on the CMS, the menubar settings, the screen width, the number of items in the menu, etc. CSS variables to the rescue!

Comments

Inspired by @aydun's comment https://chat.civicrm.org/civicrm/pl/w3f97iskebr5uy7desymcjc54e

@civibot
Copy link

civibot bot commented May 24, 2023

(Standard links)

@civibot civibot bot added the master label May 24, 2023
@aydun
Copy link
Contributor

aydun commented May 24, 2023

r-run: ok - works as expected on D7 with and without the drupal menu exposed.

I like the new class - much better than the css hack as you can choose per table whether to use sticky headers.

@colemanw
Copy link
Member Author

Thanks @aydun FYI I've also run it in Wordpress with various permutations of screen width and menubar settings.

@colemanw colemanw added the merge ready PR will be merged after a few days if there are no objections label May 24, 2023
@colemanw colemanw merged commit f724240 into civicrm:master May 25, 2023
@colemanw colemanw deleted the stickyHeader branch May 25, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants