-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes obsolete "Serbia and Montenegro" on civicrm_country.tpl #26328
Conversation
"Serbia and Montenegro" is still listed as common entity even if the ISO made a change separating both countries in 2006. "Serbia" and "Montenegro" are already listed with their correct ISO codes.
Can one of the admins verify this patch? |
(Standard links)
|
Can one of the admins verify this patch? |
jenkins ok to test |
@totten @seamuslee001 does bknix-run-a1n5z9 have an older config/snapshot on it? Test fail, but I don't think it's related to the PR:
Separately @quimgil this will also need to run regen.sh to update civicrm_generated.sql (can also run it online in your fork). |
jenkins retest this please |
I'll put the regen up separately. |
@demeritcowboy Thank you for accepting the patch. About the credits, it's ok. It's such a small patch and it was a colleague who noticed the duplication in the list. Let's leave it here. :) |
"Serbia and Montenegro" is still listed as common entity even if the ISO made a change separating both countries in 2006. "Serbia" and "Montenegro" are already listed with their correct ISO codes.
Overview
A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.
Before
What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
After
What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
Technical Details
If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.
Comments
Anything else you would like the reviewer to note