Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Scheduled Jobs admin page #26317

Merged

Conversation

larssandergreen
Copy link
Contributor

Before

Table overflowing because of use of <pre> tags.
Execute Now hidden under menu, when I think this is much more commonly used than Edit.
One PHP8 warning.
image

image

After

Table no longer overflows, params shown with nl2br.
Execute easily accessible, name shortened (this translation string already exists).
No warning.
image
Maybe not ideal display of params, but better than having the table overflow a lot. If you need to seriously examine the params, you can still click through to edit. Only a few scheduled jobs have params by default.
image

@civibot civibot bot added the master label May 24, 2023
@civibot
Copy link

civibot bot commented May 24, 2023

(Standard links)

@colemanw
Copy link
Member

FYI @aydun is working to replace this entire screen. See #26060

@larssandergreen
Copy link
Contributor Author

@colemanw Ah, oh well, should have checked. I think still worth fixing the broken table here though.

@colemanw
Copy link
Member

No it's fine @larssandergreen - the Admin UI Extension is still optional so it's not going to get replaced right away. It was just an FYI.
This PR is still good. Thanks.

@colemanw colemanw merged commit 41ca0f4 into civicrm:master May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants