Api4: add calculated field contact_count to Group
#26313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
May 23, 2023
This provides the current count of 'added' group members and smart group members. Note this does not rebuild the group cache so smart group counts may be out of date or zero. See https://stackoverflow.com/questions/47918929/coalesce-for-zero-instead-of-null/47919047#47919047 for the COALESCE(NULLIF()) construct.
|
Great thanks @aydun - I've added a simple test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds a calculated field 'contact_count
to theGroup.get()` API. This provides the current count of 'added' group members and smart group members. Note this does not rebuild the group cache so smart group counts may be out of date or zero.Before
Cannot get count of smart group contacts.
After
Count of smart group contacts available as
contact_countfieldTechnical Details
Contacts manually added to a smart group are included in the
civicrm_group_contact_cachetable. So if the count from that table is non-zero, the group is smart and the count is the total number of contacts. If the count is zero, either the group is not smart, or the cache table has not been rebuilt. Either way, report the number of contacts incivicrm_group_contactComments
Anything else you would like the reviewer to note