Replace isset with token for pay_later_receipt #26299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As tested in https://github.com/civicrm/civicrm-core/pull/26294/files#diff-a5d237ba4e392d0e8ad764a535315f0b1101cc5ca61c39b4e572de42f5c6b4bcR676 this token works & removes one of the breaky issets
|
(Standard links)
|
|
@eileenmcnaughton |
|
@eileenmcnaughton |
|
@yashodha yeah - we have been waiting until there is a critical mass of changes to push-upgrade people |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Replace isset with token for pay_later_receipt
Before
Use of
issetin templates causes hard-errors with smarty-secure mode enabledAfter
Replaced with a token, this is also previewable
Technical Details
As tested in https://github.com/civicrm/civicrm-core/pull/26294/files#diff-a5d237ba4e392d0e8ad764a535315f0b1101cc5ca61c39b4e572de42f5c6b4bcR676 this token works & removes one of the breaky issets
Comments