dev/core#4287 Fix event_offline template phones & emails

[eileenmcnaughton]

Overview

Fix event_offline template phones & emails

https://lab.civicrm.org/dev/core/-/issues/4287

Before

We have reports of the old smarty variables causing havoc

After

Using (tested) tokens - we can now preview them in Message Admin & see how they look...

Technical Details

Comments

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

This doesn't seem to be working for me. I get almost the same E_NOTICEs before and after, and now the phones don't get output. I can't check the test site here because the ability to redirect-to-database was blocked a few months ago. Will try to check another install.

(Some of the notices aren't related to location info so those would be out of scope, but the main thing I'd say would be the phones are missing.)

[demeritcowboy]

If I log the compiled smarty before it calls eval() I can see that
{if {event.loc_block_id.phone_id.phone|boolean}}
is coming out as
<?php if (0): ?>

and {event.loc_block_id.phone_id.phone} is blank.

[demeritcowboy]

Ah I see whatever cache these tokens are using doesn't get cleared when you edit an event location (or at least when you add a phone). That's not the PR's fault but that seems like a little bit of a bug.

So I'll merge, and then this will need regen too. There are still warnings in the output, but they're from other things in the template.

[eileenmcnaughton]

@demeritcowboy thanks for testing & merging & yeah the caching is a bit of a gotcha!