[REF][PHP8.2] Declare campaigns property #26293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Declare
campaigns
property inCRM_Report_Form
.Before
17 different report classes call
addCampaignFields
, which was dyamically setting$this->campaigns
and therefore triggering a deprcation notice on PHP 8.2.After
The campaigns property is properly declared. This should reduce the number of tests failing on PHP 8.2.
Comments
There is still lots more to do on reports - this is just 1 step towards full PHP 8.2 compatiability.