Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF][PHP8.2] Declare campaigns property #26293

Merged
merged 1 commit into from
May 21, 2023

Conversation

braders
Copy link
Contributor

@braders braders commented May 21, 2023

Overview

Declare campaigns property in CRM_Report_Form.

Before

17 different report classes call addCampaignFields, which was dyamically setting $this->campaigns and therefore triggering a deprcation notice on PHP 8.2.

After

The campaigns property is properly declared. This should reduce the number of tests failing on PHP 8.2.

Comments

There is still lots more to do on reports - this is just 1 step towards full PHP 8.2 compatiability.

@civibot
Copy link

civibot bot commented May 21, 2023

(Standard links)

@civibot civibot bot added the master label May 21, 2023
@eileenmcnaughton eileenmcnaughton merged commit 06fec83 into civicrm:master May 21, 2023
@colemanw
Copy link
Member

Nice @braders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants