Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up redundant descriptions and broken help on import forms #26290

Conversation

larssandergreen
Copy link
Contributor

@larssandergreen larssandergreen commented May 21, 2023

Overview

Just a bit of UI clean up to make the first step of the import forms less busy and more functional. Also removed some very lengthy help texts that were not accessible from anywhere, so were just translation work for no benefit (this detail is covered, better, in the docs).

Before

Redundant descriptions, help doesn't work on some non-contact import form links, incorrect text.

For example:
image

After

Cleaner, help text works, removed incorrect text.

image

@civibot
Copy link

civibot bot commented May 21, 2023

(Standard links)

@civibot civibot bot added the master label May 21, 2023
@larssandergreen
Copy link
Contributor Author

jenkins, test this please

@larssandergreen larssandergreen force-pushed the Continue-remove-unneeded-field-descriptions branch from 7e79e6c to bcb1fe3 Compare May 21, 2023 23:20
@larssandergreen larssandergreen force-pushed the Continue-remove-unneeded-field-descriptions branch from bcb1fe3 to 7ae9475 Compare May 23, 2023 15:14
@mlutfy
Copy link
Member

mlutfy commented May 30, 2023

Spotting the differences was not super obvious to my sleep-deprived mind, but once you see them, I think they make sense.

I tested the patch and works for me.

Thank you @larssandergreen !

@mlutfy mlutfy merged commit 6acc2ef into civicrm:master May 30, 2023
@larssandergreen
Copy link
Contributor Author

Thanks @mlutfy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants