dev/core#4305 - Fix pluses being turned into spaces in hook_alterAngular

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/4305

Before

1. Implement hook_alterAngular on a file that contains an href tag where its value is an angular expression using +.
2. Even if your hook doesn't change anything, just calling addChangeset breaks the href attribute.

After

It still does, but it's now an ng-href which doesn't have the problem, which the angular docs suggest using for other reasons too.

Technical Details

See lab ticket. I don't think this is workaroundable in a consistent way in Civi\Angular\Coder so that you could still use regular href.

Comments

Has test, sort of.

[civibot]

No issue was found matching the number given in the pull request title. Please check the issue number.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

This is a decent workaround

[demeritcowboy]

ngThanks!

[colemanw]

@demeritcowboy maybe we should replace all href="{{...}}" with ng-href in core, to set a good example if nothing else.

[demeritcowboy]

Agreed. I left the ticket open - I was going to try to come up with some clever grep.

[colemanw]

Looks like @stesi561 beat you to it @demeritcowboy

[demeritcowboy]

ngYep