Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise casing on ids in WorkflowMessages #26281

Merged
merged 1 commit into from
May 20, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 20, 2023

bOverview

Standardise casing on ids in WorkflowMessages

Before

As @seamuslee001 noted the id fields on the Workflow messages have a mix of casing - ie contributionId but eventID, participantID, membershipID`

After

They all use consistent casing - ie contributionID

Technical Details

This resolves the inconsistencies in id fields in the workFlowMessages

My general feeling is this hasn't really been adopted outside of core as yet as it has been so immature so I'm fixing the core uses - these are all heavily tested

Comments

I added to the apiv4 changelog - not strictly an apiv4 thing but that is the supported way to call them - worth a release notes callout
https://lab.civicrm.org/documentation/docs/dev/-/blob/master/docs/api/v4/changes.md

@civibot
Copy link

civibot bot commented May 20, 2023

(Standard links)

@civibot civibot bot added the master label May 20, 2023
This resolves the inconsistencies in id fields in the workFlowMessages

My general feeling is this hasn't really been adopted outside of core as
yet as it has been so immature so I'm fixing the core uses - these are
all heavily tested
@colemanw colemanw merged commit 003d9ff into civicrm:master May 20, 2023
@colemanw colemanw deleted the better_props branch May 20, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants