Standardise casing on ids in WorkflowMessages #26281
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bOverview
Standardise casing on ids in WorkflowMessages
Before
As @seamuslee001 noted the id fields on the Workflow messages have a mix of casing - ie
contributionId
buteventID
,participantID
, membershipID`After
They all use consistent casing - ie
contributionID
Technical Details
This resolves the inconsistencies in id fields in the workFlowMessages
My general feeling is this hasn't really been adopted outside of core as yet as it has been so immature so I'm fixing the core uses - these are all heavily tested
Comments
I added to the apiv4 changelog - not strictly an apiv4 thing but that is the supported way to call them - worth a release notes callout
https://lab.civicrm.org/documentation/docs/dev/-/blob/master/docs/api/v4/changes.md