Resize mailing preview modal #26273
Merged
Resize mailing preview modal #26273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Seems like a useful change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Short and wide, not ideal for mailings, height: auto doesn't seem to work.
After
Tall with width of 800px, which should be enough for any mailing.
Technical Details
Not sure why height: auto doesn't work here, but I don't see the harm in making the height 90% as I think most mailings are going to fill that. Also tried maxWidth: 800 instead to avoid a fixed width in pixels, but that did not work and also is less than ideal as it would prevent users from resizing wider themselves. If there's a better way though, I'd love to hear it.
Comments
I think this is currently only used on A/B tests.