FormBuilder: don't make 'Primary' required

[aydun]

Overview

In the FormBuilder blocks for Address, Email, IM and Phone, don't make 'Primary' required, otherwise repeated blocks fail.

Before

These FormBuilder blocks bring make 'Is Primary' radios to be required. When using the 'Multiple' option to add multiple Emails (or other), form validation fails saying Primary is required despite being selected on one entity.

After

'Primary' is not required.

Technical Details

Comments

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

I think this could be addressed at the api-metadata level. Like around here:

civicrm-core/Civi/Api4/Service/Spec/Provider/AddressCreationSpecProvider.php

Lines 26 to 28 in 45ebb03

	public function modifySpec(RequestSpec $spec) {
	$spec->getFieldByName('location_type_id')->setRequired(TRUE);
	}

[aydun]

I think this could be addressed at the api-metadata level.

Ok, changed to use that approach.

[colemanw]

Did that have the same effect on Afforms @aydun ?

[aydun]

Yes, those blocks load with 'primary' not being a required field.

[colemanw]

This is a good change thanks @aydun. I think these fields actually weren't originally required but were accidentally changed during the big boolean cleanup of '22.