Remove unused variables from previously-shared function #26264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
buildMembershipBlock
function was unshared by @mattwire a while ago due to the usual business of cramming all sorts of unshared stuff into a shared function. Per the code comments follow on cleanup was required to get rid of the cruft not relevant to all 3 forms.In particular a lot of it is only relevant to the Main form - which has the input fields. This removes some variables from the other two
$radioOptAttrs
is set & unuset but never used - this makes sense as the point of it is to about adding options to a field on the Main contribution page - which no longer shares this function.$radio
is set & unset but never used$allowAutoRenewMembership
is set but never used$javascriptMethod
is set but only used to add to$radioOptAttrs