Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variables from previously-shared function #26264

Merged
merged 1 commit into from
May 19, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented May 19, 2023

The buildMembershipBlock function was unshared by @mattwire a while ago due to the usual business of cramming all sorts of unshared stuff into a shared function. Per the code comments follow on cleanup was required to get rid of the cruft not relevant to all 3 forms.

In particular a lot of it is only relevant to the Main form - which has the input fields. This removes some variables from the other two

  • $radioOptAttrs is set & unuset but never used - this makes sense as the point of it is to about adding options to a field on the Main contribution page - which no longer shares this function.

  • $radio is set & unset but never used

  • $allowAutoRenewMembership is set but never used

  • $javascriptMethod is set but only used to add to $radioOptAttrs

@civibot
Copy link

civibot bot commented May 19, 2023

(Standard links)

@civibot civibot bot added the master label May 19, 2023
radioOptAttrs is set & unuset but never used - this makes sense as the
point of it is to about adding options to a field on the Main
contribution page - which no longer shares this function.
@eileenmcnaughton eileenmcnaughton changed the title Remove unused variable from previously-shared function Remove unused variables from previously-shared function May 19, 2023
@colemanw colemanw merged commit 1930140 into civicrm:master May 19, 2023
@colemanw colemanw deleted the unshared branch May 19, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants