Create export mappings without admin perms #26262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@MegaphoneJon I agree with this change - but should we target the rc? |
|
I'm good with this as well |
|
I mean - we could target the rc, but this regressed in...5.37? It's not recent at all. I manually confirmed it happened in 5.53. |
|
@MegaphoneJon so I guess my general principle would be to target the rc for anything that is
Having said that this is against master & it exists & is mergeable with the click of a button so I'm all good with not creating more work here given the lack of recency |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
https://lab.civicrm.org/dev/core/-/issues/2435
Import mappings, and AFAICT export mappings before
ang/exportui, don't require admin permissions to create. However, the Mapping API required admin permissions, but that's a default that I imagine no one ever changed.With the advent of
ang/exportui, one could no longer save an export mapping without admin permissions. This corrects that.Note that Coleman created #19733 to make the UI match the permission, intentionally sidestepping the permission question. I can't see any reason not to change the permission though.
Before
Non-admin users don't have a "Save Fields" button in the Export UI.
After
"Save Fields" appears.
Comments
My only "real" change is in
CRM/Core/Permissions.php. The other files are reverting Colemans' alternate fix.