-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternate Manage groups in Admin UI extension #26261
Conversation
(Standard links)
|
@samuelsov this looks great, except there are a couple things missing in the |
@colemanw Ok, I was avoiding regenerating because of the extra spaces issues in the generator (start + end of line). Should be good now. |
ext/civicrm_admin_ui/managed/SavedSearch_Administer_Manage_Group.mgd.php
Show resolved
Hide resolved
ext/civicrm_admin_ui/managed/SavedSearch_Administer_Manage_Group.mgd.php
Show resolved
Hide resolved
@samuelsov I never notice those because my IDE automatically strips trailing whitespace. But yea that would be a nice-to-fix thing in the Explorer. |
@samuelsov this looks good now. Ideally it would get squashed into a single commit before merging - could you do that? |
Nice job @samuelsov ! r-run: all seems good, except that on loading it is filtering by |
I've fixed the default form value and while I was at it I squashed the commits. Good to merge. |
Overview
Add "Manage group" to Admin UI extension
Differences from the original page:
Missing features:
I don't think anything prevents this for being committed at this stage except PR-26260.