Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate Manage groups in Admin UI extension #26261

Merged
merged 1 commit into from
May 20, 2023

Conversation

samuelsov
Copy link
Contributor

Overview

Add "Manage group" to Admin UI extension

Differences from the original page:

  • "Name" column becomes "Title"
  • New column for "Public Title"
  • New column "Parents" (see PR-26260 for remaining issues)
  • instead of writing "smart group", use an icon
  • Disable/Enable is now a column instead of a button

Missing features:

  • no way to display or refresh count for smart groups
  • no hierarchy
  • default to "Enabled" doesn't work

I don't think anything prevents this for being committed at this stage except PR-26260.

ksnip_20230518-112848

@civibot
Copy link

civibot bot commented May 18, 2023

(Standard links)

@civibot civibot bot added the master label May 18, 2023
@colemanw
Copy link
Member

@samuelsov this looks great, except there are a couple things missing in the .mgd.php file - did you export it with the API Explorer using the latest master of CiviCRM? The Explorer's PHP output should have auto-wrapped the strings in E::ts() and it also should have added "match" params to the output.

@samuelsov
Copy link
Contributor Author

@colemanw Ok, I was avoiding regenerating because of the extra spaces issues in the generator (start + end of line). Should be good now.

@colemanw
Copy link
Member

I was avoiding regenerating because of the extra spaces issues in the generator (start + end of line).

@samuelsov I never notice those because my IDE automatically strips trailing whitespace. But yea that would be a nice-to-fix thing in the Explorer.

@colemanw
Copy link
Member

@samuelsov this looks good now. Ideally it would get squashed into a single commit before merging - could you do that?

@aydun
Copy link
Contributor

aydun commented May 19, 2023

Nice job @samuelsov !

r-run: all seems good, except that on loading it is filtering by enabled = yes, but the radio button does not show Yes selected. If you then click the 'x' to clear it, both enabled and disabled are shown. But that's probably a FormBuilder issue for @colemanw rather than anything do with this PR.

@colemanw
Copy link
Member

I've fixed the default form value and while I was at it I squashed the commits. Good to merge.

@eileenmcnaughton eileenmcnaughton merged commit d693066 into civicrm:master May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants