dev/core#3961 - Modify psr-0 namespaces of component extensions to match core #26256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issue was found matching the number given in the pull request title. Please check the issue number. |
|
(Standard links)
|
|
This seems fine to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a naming conflict between the new stub extensions added in #26036 and the existing Compucorp CiviCase extension by aligning the new extensions with the naming pattern of core components.
Before
Fatal error: Cannot declare class CRM_Civicase_ExtensionUtil, because the name is already in useAfter
No error, code is better aligned with existing components.
Technical Details
I went ahead and made this change to all the stub extensions, because I like consistency and it might simplify the process of moving CRM_* files into the extensions.