Add is_active to link spec #26255
Merged
Add is_active to link spec #26255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the process of adding weights to the links it occurred to me that it might be cleaner in some cases for hooks to fiddle with 'is_active' rather than setting & unsetting. An example would be that instead of excluding a link that our core code thinks should not be available we could include it with is_active = FALSE & a hook could enable it. I figured if it I add it now then while adding weights I could bank it in too
|
(Standard links)
|
|
@colemanw thoughts? It's not a big thing - but I figured it adding weight it made sense to add this too. Might simplify some code around the adding & removing link elements |
|
Seems like a cheap and useful thing to do, and it's an existing pattern 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of adding weights to the links it
occurred to me that it might be cleaner in some cases for hooks to fiddle with 'is_active' rather than setting & unsetting.
An example would be that instead of excluding
a link that our core code thinks should not be available we could include it with is_active = FALSE &
a hook could enable it.
I figured if it I add it now then while adding weights I could add it in too